Colors.jl icon indicating copy to clipboard operation
Colors.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaGraphics

Road to 1.0

Open timholy opened this issue 5 years ago • 13 comments
trafficstars

I'd like to move the whole JuliaImages stack to version numbers >= 1.0 (see JuliaImages/Images.jl#825). Let's use this issue to collect plans for breaking changes in the near future.

Issues/PRs on my agenda:

  • [X] #360
  • [x] #353
  • [ ] possibly #349, but I worry that will take a while and hence might be 2.0 material
  • [x] #273 (ugh)

timholy avatar Nov 22 '19 19:11 timholy

  • A part of #354?

Actually, I have forgotten how far I have worked :sweat_smile:, but somethings should have already been achieved. https://github.com/JuliaGraphics/Colors.jl/compare/master...kimikage:cnvt

However, there are few breaking changes other than the bug fixes. In regards to the white point wp, it follows the current interface (convert(::Type{C}, c::Color, wp::XYZ)), but it is necessary to discuss how white points should be handled.

kimikage avatar Nov 23 '19 10:11 kimikage

You have done wonders for these packages.

"Cleanups" can be done after 1.0 if they don't break the public API. If we grossly change the result of a white-point aware conversion, though, that is certainly breaking.

timholy avatar Nov 23 '19 11:11 timholy

  • [x] #371 following #353

kimikage avatar Dec 08 '19 02:12 kimikage

CC @cormullion

  • Tidy the logo up (cf. https://github.com/JuliaLang/julia-logo-graphics)

It may be useful for the testing to add "julia_blue", "julia_green", "julia_purple" and "julia_red" to the named colors. I also feel that "nationalism" is too much, though. :smile:

kimikage avatar Dec 09 '19 02:12 kimikage

No problem. What do you mean by "I also feel that "nationalism" is too much, though."?

cormullion avatar Dec 09 '19 09:12 cormullion

Adding "julia_blue" etc. to the named colors is not necessarily a public interest. "Colors of the Julia users, by the Julia users, for the Julia users!"

kimikage avatar Dec 09 '19 09:12 kimikage

Ah, I see. :) Anyway, probably not many people use them (apart from me, I expect)...

cormullion avatar Dec 09 '19 10:12 cormullion

Reminder: https://github.com/JuliaGraphics/Colors.jl/issues/353#issuecomment-570967804

kimikage avatar Jan 06 '20 01:01 kimikage

  • [ ] #496

kimikage avatar Aug 02 '21 11:08 kimikage

If there breaking changes in master currently ? I wanted to use some of the XYZ to RGB conversion but last release was before it was added (27 Apr 2021). Would it be possible to make a minor release before 1.0 ?

jonathanBieler avatar Sep 14 '22 12:09 jonathanBieler

Yeah, we need to do something about this. I am pretty swamped with TTFX work until at least mid-October, unfortunately. If you'd be willing to figure out what to do perhaps we could review your work and then make a release.

timholy avatar Sep 14 '22 19:09 timholy

I had a look at the merged PRs and there's a couple labelled as breaking since last release :

  • #478
  • #479
  • #494
  • #504

Otherwise it's mostly performance & accuracy improvements, with a few new features (polar_to_cartesian, weighted_color_mean, ...). I don't see serious open issues either, so it seems reasonable to make a new release. But maybe @kimikage has a different opinion ?

jonathanBieler avatar Sep 15 '22 08:09 jonathanBieler