Meshes.jl icon indicating copy to clipboard operation
Meshes.jl copied to clipboard

Weiler atherton clipping method

Open jnemanja opened this issue 1 year ago • 8 comments
trafficstars

In draft because testing should have more cases and documentation probably needs some improvements. An extra commit is added with informal testing used during development, which is to be discarded before merge.

jnemanja avatar Aug 12 '24 16:08 jnemanja

Codecov Report

Attention: Patch coverage is 91.40271% with 19 lines in your changes missing coverage. Please review.

Project coverage is 87.85%. Comparing base (243d3f0) to head (2a2f4cb). Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
src/clipping/weileratherton.jl 91.40% 19 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
+ Coverage   87.69%   87.85%   +0.16%     
==========================================
  Files         191      192       +1     
  Lines        6005     6226     +221     
==========================================
+ Hits         5266     5470     +204     
- Misses        739      756      +17     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

codecov[bot] avatar Aug 29 '24 10:08 codecov[bot]

Added tests to reach full coverage. Also, in the process I noticed that the order of rings in the polygons with holes is not always proper, so added a fix for that.

jnemanja avatar Aug 30 '24 08:08 jnemanja

And rebased to latest again.

jnemanja avatar Aug 30 '24 08:08 jnemanja

And rebased to the newest version.

jnemanja avatar Sep 01 '24 12:09 jnemanja

@jnemanja did you have a chance to take a look into this PR?

juliohm avatar Sep 18 '24 12:09 juliohm

@jnemanja did you have a chance to take a look into this PR?

I am not aware of any additional issues I should address. If I missed something, could you point it out.

jnemanja avatar Sep 18 '24 12:09 jnemanja

I believe that tests will fail with the latest commits, but I did trigger the bot again to be sure.

juliohm avatar Sep 18 '24 13:09 juliohm

I believe that tests will fail with the latest commits, but I did trigger the bot again to be sure.

The tests were successful, but the docs failed. Fixed that now and rebased to the newest release.

jnemanja avatar Sep 18 '24 19:09 jnemanja