TemporalGPs.jl icon indicating copy to clipboard operation
TemporalGPs.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaGaussianProcesses

Address type piracy compilation failures (fix #120)

Open sefffal opened this issue 1 year ago • 4 comments

This PR just removes some apparently unneeded diff rules that pirated static arrays. Running ]test TemporalGPs passes after removing these lines.

sefffal avatar Dec 21 '23 16:12 sefffal

cc @willtebbutt

sefffal avatar Dec 21 '23 16:12 sefffal

Hi all, I know there is work on a migration to Enzyme, but in the meantime could we look at merging this PR or similar? I'm still getting compilation errors in OctofitterRadialVelocity on 1.10 due to this issue.

Thanks for your help!

sefffal avatar Apr 03 '24 17:04 sefffal

Hi @sefffal -- sorry for dropping this. I'm just running CI again to see if the tests start passing. I'm happy to merge if they do, and to assist debugging if they don't. I agree that it would be good to get this sorted.

willtebbutt avatar Apr 03 '24 17:04 willtebbutt

@willtebbutt thanks so much! It's no problem, I have a mountain of OSS issues to tackle myself ;)

It looks like my changes were a little over broad and causing failures, we might need to be more surgical and just remove the one offending method.

sefffal avatar Apr 03 '24 17:04 sefffal

Closing as this is now outdated. Please feel free to re-open if you feel there's more to be done.

willtebbutt avatar Sep 27 '24 18:09 willtebbutt