KernelFunctions.jl icon indicating copy to clipboard operation
KernelFunctions.jl copied to clipboard

GPU Attempt 2

Open willtebbutt opened this issue 3 years ago • 3 comments

Summary

Supercedes #470 . I messed up some of my gitconfig stuff and had commits with the wrong username etc. Easiest thing was to start again

Proposed changes

  • ...

What alternatives have you considered?

Breaking changes

edit:

TODO:

  1. sort out codecov on buildkite branch
  2. sort out formatting

willtebbutt avatar Aug 31 '22 17:08 willtebbutt

Codecov Report

Base: 90.00% // Head: 86.53% // Decreases project coverage by -3.47% :warning:

Coverage data is based on head (12fe669) compared to base (dede8a0). Patch coverage: 18.57% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   90.00%   86.53%   -3.48%     
==========================================
  Files          52       53       +1     
  Lines        1351     1478     +127     
==========================================
+ Hits         1216     1279      +63     
- Misses        135      199      +64     
Impacted Files Coverage Δ
src/KernelFunctions.jl 100.00% <ø> (ø)
src/distances/cuda.jl 0.00% <0.00%> (ø)
src/TestUtils.jl 47.36% <6.55%> (-47.37%) :arrow_down:
src/basekernels/fbm.jl 96.07% <77.77%> (-3.93%) :arrow_down:
src/basekernels/exponential.jl 100.00% <100.00%> (ø)
src/basekernels/matern.jl 100.00% <100.00%> (ø)
src/basekernels/wiener.jl 92.85% <100.00%> (ø)
src/transform/scaletransform.jl 100.00% <0.00%> (+13.33%) :arrow_up:
src/transform/periodic_transform.jl 50.00% <0.00%> (+20.00%) :arrow_up:
src/transform/transform.jl 100.00% <0.00%> (+40.00%) :arrow_up:
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 31 '22 18:08 codecov[bot]

@theogf there are a couple of minor things left to do, but I think this is defintely ready for review

willtebbutt avatar Aug 31 '22 21:08 willtebbutt

@willtebbutt Do you think it will take some time to sort out all remaining comments and issues in this PR? If so, we could add only the buildkite configuration as a first step to fix CI errors and add GPU-specific tests in a follow-up PR, similar to https://github.com/JuliaGaussianProcesses/AbstractGPs.jl/pull/335.

That would be ideal. I thought I was going to have time to follow up on this immediately, but it's actually going to be a little while. If you could open a PR like the one you made to AbstractGPs, that would be ideal.

willtebbutt avatar Sep 26 '22 11:09 willtebbutt