KernelFunctions.jl
KernelFunctions.jl copied to clipboard
St/dw/scalar parameterhandling/merge
Merges master back into #397
Codecov Report
Merging #419 (b36342d) into dw/scalar_parameterhandling (2ccf8cf) will increase coverage by
0.33%. The diff coverage is20.00%.
@@ Coverage Diff @@
## dw/scalar_parameterhandling #419 +/- ##
===============================================================
+ Coverage 12.62% 12.96% +0.33%
===============================================================
Files 53 53
Lines 1386 1396 +10
===============================================================
+ Hits 175 181 +6
- Misses 1211 1215 +4
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/basekernels/fbm.jl | 0.00% <0.00%> (ø) |
|
| src/basekernels/matern.jl | 0.00% <0.00%> (ø) |
|
| src/distances/sinus.jl | 54.54% <0.00%> (-5.46%) |
:arrow_down: |
| src/utils.jl | 33.78% <ø> (+0.90%) |
:arrow_up: |
| src/kernels/transformedkernel.jl | 35.55% <50.00%> (ø) |
|
| src/transform/ardtransform.jl | 75.00% <100.00%> (ø) |
|
| src/zygoterules.jl | 33.33% <0.00%> (-26.67%) |
:arrow_down: |
| src/transform/chaintransform.jl | 47.36% <0.00%> (+1.42%) |
:arrow_up: |
| src/chainrules.jl | 7.59% <0.00%> (+2.40%) |
:arrow_up: |
| ... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 2ccf8cf...b36342d. Read the comment docs.
The branch is outdated, I have additional changes and fixes locally. So unfortunately it's not helpful ro merge this PR currently. I'm sorry but exactly such problems I wanted to avoid, I still think it was a bad idea to make these changes.
Well, it wasn't any work; let me know once you've pushed your local changes, I'm happy to re-do it. I still think it's not a big problem and that it was better to get the other PR in as it is.