KernelFunctions.jl icon indicating copy to clipboard operation
KernelFunctions.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaGaussianProcesses

Make Zygote work for Wiener kernel

Open sharanry opened this issue 5 years ago • 5 comments

#116

I have defined kernelmatrix for wiener kernel. This avoid the "slow method" ~~but gives NaNs in the Zygote gradient~~.

sharanry avatar Sep 15 '20 07:09 sharanry

The NaN values in the Zygote gradient seem to be caused by the the pairwise(Euclidean(), x, y). I am not sure why this is happening.

sharanry avatar Sep 15 '20 10:09 sharanry

Can you try the Zygote master branch locally? Maybe it was fixed by https://github.com/FluxML/Zygote.jl/pull/787.

devmotion avatar Sep 15 '20 10:09 devmotion

Can you try the Zygote master branch locally? Maybe it was fixed by FluxML/Zygote.jl#787.

Thanks! The Zygote and ForwardDiff tests pass on Zygote#master. However, ReverseDiff fails, probably requires nan checking.

sharanry avatar Sep 15 '20 12:09 sharanry

There's a new Zygote version which contains the fix mentioned above.

devmotion avatar Sep 15 '20 21:09 devmotion

It is weird that Zygote on Gabor kernel tests are failing on Mac without any changes related to it. https://travis-ci.com/github/JuliaGaussianProcesses/KernelFunctions.jl/jobs/386076575#L369

sharanry avatar Sep 17 '20 06:09 sharanry

This looks to be stale, so I'm closing.

willtebbutt avatar Sep 15 '23 19:09 willtebbutt