ApproximateGPs.jl icon indicating copy to clipboard operation
ApproximateGPs.jl copied to clipboard
verified publisher icon JuliaGaussianProcesses

Examples don't use correct version of ApproximateGPs

Open devmotion opened this issue 3 years ago • 3 comments

I didn't see any discussion about this so I assume that https://github.com/JuliaGaussianProcesses/ApproximateGPs.jl/pull/99 might have changed it unintentionally and introduced a bug: In contrast to previous behaviour and when e.g. building the documentation, with this PR now examples use the latest compatible released version of ApproximateGPs instead of e.g. the master branch or a PR. So it can happen that examples run fine in a PR but fail as soon as the next release is tagged.

devmotion avatar Jan 29 '22 21:01 devmotion

Woops, yes, definitely an unintentional bug. Thanks for spotting it!

st-- avatar Jan 31 '22 13:01 st--

fixed by #119

st-- avatar Mar 17 '22 16:03 st--

That's only a workaround, not a proper fix. The manifest files and package information obtained with the linked PR (which BTW introduced formatting issues and should not have been merged it seems) are not helpful for reproducing the examples. Instead of the development version they should use the corresponding release or commit if run on the master branch.

devmotion avatar Mar 17 '22 16:03 devmotion