GPUCompiler.jl icon indicating copy to clipboard operation
GPUCompiler.jl copied to clipboard

Redo "Annotate exception handling with call site effects (#359)"

Open vchuravy opened this issue 2 years ago • 3 comments

Redo the non-PTX related changes from #359 that got reverted in #388.

vchuravy avatar Feb 06 '23 17:02 vchuravy

Will run Oceananigans testuite over this alone later this today/this week.

vchuravy avatar Feb 06 '23 20:02 vchuravy

Codecov Report

Base: 86.98% // Head: 87.01% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (9544c3b) compared to base (3ad8bcc). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   86.98%   87.01%   +0.02%     
==========================================
  Files          24       24              
  Lines        2835     2841       +6     
==========================================
+ Hits         2466     2472       +6     
  Misses        369      369              
Impacted Files Coverage Δ
src/irgen.jl 95.05% <100.00%> (+0.02%) :arrow_up:
src/utils.jl 98.03% <100.00%> (+0.16%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Feb 06 '23 22:02 codecov[bot]

@wsmoses some concerns by @jpsamaroo in https://github.com/JuliaGPU/GPUCompiler.jl/pull/359#issuecomment-1420848278

vchuravy avatar Feb 07 '23 14:02 vchuravy