CUDA.jl icon indicating copy to clipboard operation
CUDA.jl copied to clipboard
verified publisher icon JuliaGPU

Support for qr of strided inputs (non-contiguous views)

Open evelyne-ringoot opened this issue 2 years ago • 7 comments

Adding view support for CUDA.jl QR and tests

evelyne-ringoot avatar Feb 09 '23 22:02 evelyne-ringoot

Looks like some more functions will need their signatures widened (as CI shows fallback functionality being hit).

maleadt avatar Feb 10 '23 10:02 maleadt

These two https://github.com/JuliaGPU/GPUArrays.jl/blob/b2f396dabdab907866b885cd7abb647214cddace/src/host/linalg.jl#L33-L34 are implemented for dense Arrays, but not for strided arrays. So we end up https://github.com/JuliaLang/julia/blob/c0d2c574d44231dba39f90d6a6b27448f71763ca/stdlib/LinearAlgebra/src/transpose.jl#L76-L77

vchuravy avatar Feb 10 '23 13:02 vchuravy

No reason those shouldn't be an AnyGPUArray.

maleadt avatar Feb 10 '23 13:02 maleadt

Changed this in https://github.com/JuliaGPU/GPUArrays.jl/pull/452

evelyne-ringoot avatar Feb 13 '23 22:02 evelyne-ringoot

I've tagged GPUArrays 8.6.3 with this fix.

maleadt avatar Feb 15 '23 06:02 maleadt

Linking https://github.com/JuliaLang/LinearAlgebra.jl/issues/986 for the dimension issues in the tests

evelyne-ringoot avatar Feb 24 '23 15:02 evelyne-ringoot

Pending support for in-place qr of views Linking https://github.com/JuliaGPU/GPUArrays.jl/pull/458 for necessary changes in LinearAlgebra

evelyne-ringoot avatar Mar 07 '23 05:03 evelyne-ringoot