AMDGPU Stable Website on Gitlab and JuliaHub Not Updated

[doswellf]

A minor omission but critical for new users of AMDGPU.jl get_global_pointer:

The github source contains the fix: AMDGPU.Device.get_global_pointer on the page for global variables and pointers. Neither of JuliaHub or GitLab stable documentation have this fix; they still present the outdated code:

function my_kernel(A) idx = workitemIdx().x ptr = AMDGPU.get_global_pointer(Val(:myglobal), Float32) A[idx] += Base.unsafe_load(ptr) nothing end

which should be:

function my_kernel(A) idx = workitemIdx().x ptr = AMDGPU.Device.get_global_pointer(Val(:myglobal), Float32) A[idx] += Base.unsafe_load(ptr) nothing end

[jpsamaroo]

Sorry about that! The PR that made that change moved a lot of things around, so I'm sure there are some other things that are also out of date. I would appreciate PRs to fix these :smile:

[doswellf]

Just got ROCM working with my Radeon RX 6700 XT. Had to add the lib and include directory for almost everything under /opt/rocm to my environment setup script. Then used Julia 1.9.0rc1 with the latest AMDGPU.jl to get the tests for AMDGPU.jl to finish. Now that that the script is relatively complete, will have test to test earlier Julia versions too.

Will track any example that doesn't work in any examples and also in the SciML ecosystem. SciML Book, SciML Tutorials and SciML Benchmarks are great for uncovering omissions, updates and errors.

On 2023-03-20 21:54, Julian Samaroo wrote:

Sorry about that! The PR that made that change moved a lot of things around, so I'm sure there are some other things that are also out of date. I would appreciate PRs to fix these 😄

— Reply to this email directly, view it on GitHub https://github.com/JuliaGPU/AMDGPU.jl/issues/396#issuecomment-1477174243, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXOUN3O7S55KRAOS4X5FADW5EC4LANCNFSM6AAAAAAWAONVXY. You are receiving this because you authored the thread.Message ID: @.***>