AMDGPU.jl icon indicating copy to clipboard operation
AMDGPU.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaGPU

Added support for AnyROCArrays for GPUArrays.mapreducedim!.

Open matinraayai opened this issue 2 years ago • 4 comments

Hello @maleadt @jpsamaroo, On my side, this commit seems to add support for AnyROCArrays in GPUArray.mapreducedim!, and it assumes that the passed array is located on the default device. Please let me know when you're done working on the device API for AMDGPU so that I can add that in. Matin

matinraayai avatar Jun 26 '22 17:06 matinraayai

@matinraayai would you mind adding a test for this?

jpsamaroo avatar Jun 27 '22 14:06 jpsamaroo

@jpsamaroo aren't these tested in GPUArrays.jl? https://github.com/JuliaGPU/GPUArrays.jl/blob/master/test/testsuite/reductions.jl I wasn't able to find the corresponding CUDA.jl for this either.

matinraayai avatar Jun 28 '22 14:06 matinraayai

The specific invocation requiring an AnyROCArray couldn't have been tested in GPUArrays or AMDGPU.jl wouldn't have passed tests before. Ideally we add that test in GPUArrays.jl though.

maleadt avatar Jun 28 '22 18:06 maleadt

@matinraayai you'll need to rebase on AMDGPU master so that you get the device call.

jpsamaroo avatar Jul 29 '22 15:07 jpsamaroo

@matinraayai bump

jpsamaroo avatar Aug 25 '22 17:08 jpsamaroo

Seems like you accidentally force-pushed the wrong branch here @matinraayai

jpsamaroo avatar Sep 12 '22 17:09 jpsamaroo

@jpsamaroo I forgot I had this PR from master. Not sure how to revert it.

matinraayai avatar Sep 18 '22 20:09 matinraayai

I'm going to close the PR since I have rocSparse things in my fork's master branch. Link to new PR: https://github.com/JuliaGPU/AMDGPU.jl/pull/291

matinraayai avatar Sep 19 '22 19:09 matinraayai