AMDGPU.jl icon indicating copy to clipboard operation
AMDGPU.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaGPU

RFC: Support Adapt.AbstractGPUDevice

Open oschulz opened this issue 2 years ago • 6 comments

See JuliaGPU/Adapt.jl#52

Not functional like this yet, I don't know AMDGPU well enough and don't have a device to test, currently. See JuliaGPU/CUDA.jl#1520 for the CUDA.jl counterpart.

oschulz avatar May 22 '22 14:05 oschulz

Thanks for putting this together! CI is down while I'm out of the country, so it'll have to wait another week before I can get CI back up.

jpsamaroo avatar May 25 '22 22:05 jpsamaroo

Thanks for putting this together! CI is down while I'm out of the country

Thanks @jpsamaroo! When you're back, I'll need some hints from you on the AMDGPU side of this (I don't really know what the equivalent of CuDevice is, and so on). :-)

oschulz avatar May 26 '22 07:05 oschulz

@oschulz can you rebase this on AMDGPU master? HSAAgent is now named ROCDevice.

jpsamaroo avatar Jul 29 '22 15:07 jpsamaroo

Will do, I need to rebase the other related PRs as well anyway.

oschulz avatar Jul 29 '22 19:07 oschulz

@oschulz bump

jpsamaroo avatar Aug 25 '22 17:08 jpsamaroo

@oschulz bump

Sorry for the delay, it's not forgotten, but holidays got in the way. :-) Also looks like the whole thing will now include ArrayInterfaceCore as well (recent discussion on JuliaGPU/Adapt.jl#52). Gimme a bit of time to adapt to that, I'll modify and rebase the whole PR-complex in the process.

oschulz avatar Aug 26 '22 20:08 oschulz

Closed, but not forgotten, to be reincarnated in the future (see JuliaGPU/Adapt.jl#64).

oschulz avatar May 04 '23 13:05 oschulz