julia-emacs icon indicating copy to clipboard operation
julia-emacs copied to clipboard

Make julia-latexsub work if point in the middle of latex symbol.

Open adam-higuera opened this issue 5 years ago • 3 comments

This pull request fixes two minor issues I had:

  1. emacs was erroring off because the invoke-command machinery was calling the zero-argument function julia-latexsub with a nil argument. Removing the i in the argument specifier string fixed this (might be a Spacemacs issue, not a julia-mode issue).
  2. It wasn't doing the substitution if point is in the middle of the latex command string.

The second change seems relatively innocuous, the first might break things that invoke julia-latexsub in ways that Spacemacs doesn't, i.e. with an argument (although it hasn't broken anything for me)

adam-higuera avatar Mar 10 '19 20:03 adam-higuera

Unless I made a mistake, this doesn't work well for me: the substitution happens only if my point is within the word, not when it's at the end (in other words, the only thing which doesn't work is what was working before!). Can you confirm?

rfourquet avatar Oct 03 '19 16:10 rfourquet

I think I can make it work with the suggestion above (currently testing it in practice).

But in general, I am a bit bothered by the fact that we don't have any unit tests for completion, so I will contribute some and in the meantime hold off on this PR.

tpapp avatar Nov 08 '19 14:11 tpapp

When #81 is merged, it should also be merged to this branch, and then some tests can be added (or commented out).

tpapp avatar Nov 08 '19 15:11 tpapp

Superseded by #185

non-Jedi avatar Mar 18 '24 12:03 non-Jedi