julia-emacs icon indicating copy to clipboard operation
julia-emacs copied to clipboard

Add integration with project.el

Open non-Jedi opened this issue 4 years ago • 5 comments

This code is already used by eglot-jl to locate Julia projects and will be useful in the future for other Julia packages (such as for REPLs to decide which files they're associated with). Putting it in the julia-mode package means it doesn't have to be redefined each time it's used.

non-Jedi avatar Mar 23 '20 00:03 non-Jedi

This doesn't byte-compile cleanly on Emacs 24 since cl-defmethod was added in 25.1, however all tests pass since that section is never executed since the 'project feature was also added in 25.1. I'm sure there's a way to work around this, but I don't know how off the top of my head. Using defmethod instead of cl-defmethod isn't flexible enough in this case.

non-Jedi avatar Mar 23 '20 02:03 non-Jedi

I am wondering if any package other than eglot-jl uses/needs something like this.

Also, I am reluctant to add a feature that only works on Emacs 25+, since we still support Emacs 24.

tpapp avatar Mar 23 '20 08:03 tpapp

I found myself wanting this while working on #106, which is the reason I opened it. Still might not be worthwhile if trying to support Emacs 24.

non-Jedi avatar Mar 23 '20 11:03 non-Jedi

Can this be merged now that the minimum required Emacs version is 26.1?

berquist avatar Oct 16 '23 14:10 berquist

@berquist What's your use-case for having this code in julia-mode?

non-Jedi avatar Oct 16 '23 18:10 non-Jedi