GeoIO.jl icon indicating copy to clipboard operation
GeoIO.jl copied to clipboard

`numbertype` option not forwarded to STL format

Open paulxshen opened this issue 6 months ago • 5 comments
trafficstars

Setting numbertype = Float32 on stl or obj still produces Float64 meshes

paulxshen avatar Apr 30 '25 20:04 paulxshen

Thank you for reporting @paulxshen. Could you please share a MWE? If these file formats support single precision, we should definitely fix the behavior in GeoIO.jl. If you can submit a PR with the fix, that would be even better.

juliohm avatar Apr 30 '25 20:04 juliohm

Thanks I did PR for obj - numbertype wasn't passed to objread

paulxshen avatar May 01 '25 18:05 paulxshen

Thank you @paulxshen ! Merged #162 with the fix for OBJ. Do you also plan to submit a PR for STL?

juliohm avatar May 01 '25 19:05 juliohm

Ok done!

paulxshen avatar May 02 '25 01:05 paulxshen

Renamed the option to numtype and standardized a few other options.

juliohm avatar May 09 '25 21:05 juliohm

I have experience basically this same issue with the .ply filetype. A Float32 .ply file that I want converted to Float64 on read (which as I understand, the numtype option should do?), but the PlyIO.load_ply function does not take/use kwargs, so the conversion would need to occur in this package.

halleysfifthinc avatar May 27 '25 19:05 halleysfifthinc