ComplexityMeasures.jl icon indicating copy to clipboard operation
ComplexityMeasures.jl copied to clipboard

propagate isless in ordinal encoding

Open Datseris opened this issue 1 year ago • 6 comments

Closes #378

I'm taken aback that we didn't fix this before the paper...

Datseris avatar Jun 10 '24 15:06 Datseris

I'm taken aback that we didn't fix this before the paper...

Better now than never, though

kahaaga avatar Jun 10 '24 15:06 kahaaga

For the failing tests: I guess the result of unique(res) must be sorted?

kahaaga avatar Jun 10 '24 16:06 kahaaga

holy shit what happened I see countless failures throughout the library now :D

Datseris avatar Jun 10 '24 20:06 Datseris

i also see countless calls to deprecated functions in the test suite. Oh man, i think I have to invest some time in the tests...

Datseris avatar Jun 10 '24 20:06 Datseris

i also see countless calls to deprecated functions in the test suite. Oh man, i think I have to invest some time in the tests...

It's because we also need to test the deprecations, no? We're going to be at v3 for some time, and new users will likely never use deprecated syntax anyways, so I'm fine with just removing all the deprecations fully and releasing a new minor version stating that.

kahaaga avatar Jun 10 '24 20:06 kahaaga

The tests for ordinal patterns fail now because they were designed for cases with no random shuffling in the case of ties. Just need to pass on the correct function to restore their behavior and add a few more tests for the random case, as planned

kahaaga avatar Jun 10 '24 20:06 kahaaga