Documenter.jl
Documenter.jl copied to clipboard
JuliaDocs
```@repl block inside !!! note doesn't show output
@repl block inside an !!! note is neither stylized as the REPL nor is the output shown. Is this intended?
Can confirm. Other special blocks seem to be ignored in admonitions as well. Thanks for the report!
I'm rather sure that the issue comes from src/Expanders.jl#L25-L32 -- the expander functions are only called on top-level blocks, and not recursively through the AST.
I just stumbled upon the same problem---is it not resolved yet? Or is there a workaround?
I'd really like to see this fixed, and I'm happy to give a hand doing so. However, since there have already been two attempts which seem to eventually have run out of steam, I thought I'd ask for some input first on what people think would be the best way to resolve this.
Is there anything wrong with https://github.com/JuliaDocs/Documenter.jl/pull/1747?
#1747 contains some unnecessary changes as far as I can tell. But I think the general approach there is good (create a new expander step that recurses for certain elements, but only calls a subset of expander steps then). It needs to be updated to the new MarkdownAST-based tree though. @ettersi I'd say you're welcome to adopt that PR to finish it up if you'd like.
What's the recommended way to "adopt" a PR? I believe I can't fork a PR. I can of course create a new PR, but that would erase @jmert from the history, which doesn't seem fair.
You'd have to start a new PR on your fork, but you can use their latest commit as a starting point (although, it might be easier to just re-do it from scratch, since merging with master might be more work at this point). One way or another, I'll make sure that there is a Co-Authored-By in the commit message when we merge.