Documenter.jl icon indicating copy to clipboard operation
Documenter.jl copied to clipboard

Menu's on-hover background height feels small

Open pankgeorg opened this issue 3 years ago • 1 comments

image

pankgeorg avatar Aug 08 '22 10:08 pankgeorg

Could also do with a bit of horizontal padding.

pfitzseb avatar Aug 08 '22 10:08 pfitzseb

After increasing padding from 0 to 0.3rem it looks much better.

Before image
After image

Hetarth02 avatar Mar 01 '23 19:03 Hetarth02

@mortenpi Can you take a look at this too?

Hetarth02 avatar Mar 01 '23 20:03 Hetarth02

I feel that, rather than adding padding, we should expand the gray highlight to cover the gap between the list items:

image

Otherwise it will always "feel small" relative to the list item itself. But I think for that we need to add background color to the li, rather than the a.

Could also do with a bit of horizontal padding.

@pfitzseb Where do you actually mean? In front of the list bullet?

mortenpi avatar Mar 12 '23 22:03 mortenpi

Yeah, just add a bit of horizontal and vertical padding to the li (and add the hover effect for that instead of the anchor): image

pfitzseb avatar Mar 13 '23 10:03 pfitzseb

@pfitzseb I cannot understand what you are saying. Are you implying to add the hover effect to li tag after adding padding to the it?

If so, doing that results in this on hover, image

Hetarth02 avatar Mar 18 '23 11:03 Hetarth02

Are you implying to add the hover effect to li tag after adding padding to the it?

The idea is to fill the gap between the items, without (necessarily) changing the spacing between the items.

image

That does require having the :hover effect on the li, yes. A "problem" we have right now is that we're doing "padding" with margins in the <li>s. But it should be fine to switch to padding-* there.

Additionally, we may want to adjust the horizontal padding as well.

mortenpi avatar Mar 23 '23 03:03 mortenpi