SparseDiffTools.jl icon indicating copy to clipboard operation
SparseDiffTools.jl copied to clipboard
verified publisher icon JuliaDiff

complex number support?

Open Roger-luo opened this issue 4 years ago • 3 comments

I ran into this problem by using the AutoTsit5(Rosenbrock23()) on shordinger function (an equation that has a complex valued state), basically it seems the following line

https://github.com/JuliaDiff/SparseDiffTools.jl/blob/fb09091c195311ab622ced4889694e889631c980/src/differentiation/compute_jacobian_ad.jl#L29

won't run if x is complex-valued. I'm not sure how should this be generalized however...

Roger-luo avatar Aug 11 '21 01:08 Roger-luo

AutoTsit5(Rosenbrock23(autodiff=false)) does that work?

ChrisRackauckas avatar Aug 11 '21 01:08 ChrisRackauckas

yes, @ChrisRackauckas that works! I'm not sure what's the difference with or without AD tho?

Roger-luo avatar Aug 11 '21 04:08 Roger-luo

Not much. In some very numerically ill-conditioned problems it can matter, but most tests show little performance difference. It's really just a safety difference.

ChrisRackauckas avatar Aug 11 '21 12:08 ChrisRackauckas