ReverseDiff.jl icon indicating copy to clipboard operation
ReverseDiff.jl copied to clipboard

Realias DiffResults whenever possible

Open gdalle opened this issue 1 year ago • 2 comments

Fix #251 partially.

  • [x] Do result = operator!(result, f, x) instead of operator!(result, f, x) whenever possible (see https://github.com/JuliaDiff/DiffResults.jl/issues/27)
  • [ ] There are still some parts involving closures which I don't know how to handle.
  • [x] Adjust the tests accordingly
  • [ ] Add new tests that would fail on the current release.

@devmotion do you know the package well enough to help me figure out what I missed?

gdalle avatar Jul 28 '24 16:07 gdalle

I'm off until next week and probably won't be able to add a meaningful comment until then.

devmotion avatar Jul 30 '24 23:07 devmotion

No worries, I'll wait for your opinion!

gdalle avatar Jul 31 '24 05:07 gdalle