ForwardDiff.jl icon indicating copy to clipboard operation
ForwardDiff.jl copied to clipboard

Added furlongs test

Open stemann opened this issue 4 months ago • 5 comments

Added furlongs test - with Furlongs.jl copied from test/testhelpers in julia - implementing suggestion described in https://github.com/JuliaDiff/ForwardDiff.jl/pull/665#issuecomment-2986474538

stemann avatar Jul 28 '25 10:07 stemann

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 90.73%. Comparing base (a7991dd) to head (af8176e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #758   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files          11       11           
  Lines        1069     1069           
=======================================
  Hits          970      970           
  Misses         99       99           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 28 '25 12:07 codecov[bot]

Seems fine, but is this expected to pass without #665 ?

(I would add a big comment linking to Base to explain which code is copied, and which is new tests.)

mcabbott avatar Jul 28 '25 17:07 mcabbott

Not sure, just trying to get the ball rolling :-) @longemen3000 suggested to add this test as a separate PR.

Thoughts, @devmotion?

stemann avatar Jul 30 '25 14:07 stemann

Bump 🙂

giordano avatar Sep 19 '25 23:09 giordano

@devmotion I've added a test that demonstrates the issue outlined in https://github.com/JuliaPhysics/Measurements.jl/pull/178/files/2a41c0cd440def23343d2565ff407eb47916d854#diff-0fafde266294d0a69e0589d46875ecceac83951c1d9a1ae32c084753539ec319R10-R22 - which is fixed by #665

stemann avatar Sep 21 '25 05:09 stemann