ForwardDiff.jl icon indicating copy to clipboard operation
ForwardDiff.jl copied to clipboard

fix: Improve formula presentation

Open junyixu opened this issue 1 year ago • 6 comments

junyixu avatar Mar 25 '24 06:03 junyixu

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.57%. Comparing base (c310fb5) to head (27b4d09). Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files          11       11           
  Lines         969      969           
=======================================
  Hits          868      868           
  Misses        101      101           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 25 '24 07:03 codecov[bot]

Would be good to show the before and after in a comment

andreasnoack avatar Mar 25 '24 10:03 andreasnoack

Before: image

After: Screenshot_20240325_193632

junyixu avatar Mar 25 '24 11:03 junyixu

I'm not sure. Represent a function $f$ that maps an element $x$ in a set to another element $y$: $$f: x \mapsto y.$$ But in the original doc page, image it seems the author intended to use \to to represent a type of change.

junyixu avatar Mar 25 '24 13:03 junyixu

Sorry just went by your pictures, where after used it for two kinds of change. x to x_eps, and x_eps to f(x_eps). It seems the original commits the same sin, could fix that too?

mcabbott avatar Mar 25 '24 13:03 mcabbott

Sorry just went by your pictures, where after used it for two kinds of change. x to x_eps, and x_eps to f(x_eps). It seems the original commits the same sin, could fix that too?

I force-pushed a new commit. What do you think?

Before: image

After: image

junyixu avatar Mar 26 '24 10:03 junyixu