Diffractor.jl icon indicating copy to clipboard operation
Diffractor.jl copied to clipboard

Use rrule of KwFunc for Core.kwcall

Open nmheim opened this issue 1 year ago • 2 comments

This seems to fix non-differentiable keyword arguments by constructing the KwFunc defined in Diffractor.

nmheim avatar Feb 13 '24 10:02 nmheim

@Keno I think this does not have the same concerns that #266 has, but I am not sure. Because for reverse mode everything is already bad.

Should we do this, and reconsider it later as needed? It unbreaks a lot of tests

oxinabox avatar Feb 13 '24 10:02 oxinabox

Same as in #266 I think in order for this not to make inference worse, the method should be split into kw and non-kw versions.

Keno avatar Feb 28 '24 10:02 Keno