DiffResults.jl icon indicating copy to clipboard operation
DiffResults.jl copied to clipboard

make StaticArrays dependency into an extension

Open KristofferC opened this issue 2 years ago • 2 comments

  • Revert "Merge pull request #22 from mcabbott/static"
  • make StaticArrays dependency into an extension

Shouldn't be merged until the Registrator deployment of https://github.com/JuliaRegistries/Registrator.jl/pull/397 is done.

Note, this reverts #22 since there is no point of a Core package with an extension. This means that people on 1.8 will get the full StaticArray load time but I think that doesn't really matter since ForwardDiff loads it anyway as it is right now.

KristofferC avatar Dec 29 '22 14:12 KristofferC

Codecov Report

Base: 86.84% // Head: 86.84% // No change to project coverage :thumbsup:

Coverage data is based on head (0a4cdba) compared to base (276d1d7). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   86.84%   86.84%           
=======================================
  Files           1        2    +1     
  Lines          76       76           
=======================================
  Hits           66       66           
  Misses         10       10           
Impacted Files Coverage Δ
src/DiffResults.jl 84.84% <ø> (-2.00%) :arrow_down:
ext/StaticArraysExt.jl 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Dec 29 '22 14:12 codecov-commenter

What would you think about https://github.com/JuliaDiff/DiffResults.jl/issues/28 instead?

gdalle avatar Mar 15 '24 18:03 gdalle