ChainRulesTestUtils.jl icon indicating copy to clipboard operation
ChainRulesTestUtils.jl copied to clipboard

Change default tolerances for testers based on eltype

Open sethaxen opened this issue 4 years ago • 1 comments

The default tolerance of atol=1e-9, rtol=1e-9 for the isapprox tests seem like they might be too stringent for 32-bit checks. Perhaps we should have a utility method for settings these tolerances based on the float eltype of the inputs?

sethaxen avatar Dec 02 '20 21:12 sethaxen

yes, in general FiniteDifferences.jl doesn't work well on Float32.

oxinabox avatar Dec 02 '20 21:12 oxinabox