Support non-standard scalars in test_scalar

Open sethaxen opened this issue 5 years ago • 3 comments

test_scalar currently is very Real and Complex focused. This PR generalizes test_scalar to work the same for any scalar for which FiniteDifferences.to_vec (and a handful of base functions) are implemented.

We test it with Quaternions.Quaternion. We'd ideally test against a more minimal number, but it turns out one needs to implement quite a few base methods to get a new number to work correctly.

Oct 06 '20 21:10 sethaxen

will review tomorrow

Oct 07 '20 10:10 oxinabox

Is this ready for rereview?

Oct 27 '20 14:10 oxinabox

Is this ready for rereview?

Not yet, I'll try to finish it up this week.

Oct 27 '20 21:10 sethaxen