ChainRulesCore.jl icon indicating copy to clipboard operation
ChainRulesCore.jl copied to clipboard

add comparisons between tangents and numbers

Open oscardssmith opened this issue 3 years ago • 3 comments

useful for tests. I'm not sure whether this is a good idea, but it seems reasonable enough. @Keno

oscardssmith avatar Jun 30 '22 23:06 oscardssmith

Xref https://github.com/JuliaDiff/ChainRulesCore.jl/issues/504

mcabbott avatar Jul 01 '22 04:07 mcabbott

We removed some == methods because they were heavily invalidating https://github.com/JuliaDiff/ChainRulesCore.jl/issues/523

so it might be worth checking what the impact is here

mzgubic avatar Jul 01 '22 08:07 mzgubic

we should definitely check in validations, but I think defining == for concrete thunk subtypes should be much better on that front.

oscardssmith avatar Jul 01 '22 14:07 oscardssmith