ChainRules.jl icon indicating copy to clipboard operation
ChainRules.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaDiff

Add Tridiagonal construction rule

Open ChrisRackauckas opened this issue 1 year ago • 4 comments

Fixes https://github.com/SciML/DiffEqFlux.jl/issues/744

ChrisRackauckas avatar Nov 22 '23 15:11 ChrisRackauckas

@avik-pal

ChrisRackauckas avatar Nov 22 '23 15:11 ChrisRackauckas

If tests pass (I know one of our CIs is broken for unzip) merge and tag (minor)!when happy.

oxinabox avatar Nov 23 '23 12:11 oxinabox

Is there a minimal example of what problem this solves?

There is some chance that it would be fixed by https://github.com/JuliaDiff/ChainRulesCore.jl/pull/446 , which is really part of the original idea of ProjectTo.

mcabbott avatar Dec 31 '23 17:12 mcabbott

Not fixed just hit it here https://github.com/SciML/DiffEqFlux.jl/actions/runs/9115130596/job/25060691159?pr=922

ChrisRackauckas avatar May 16 '24 17:05 ChrisRackauckas

Once https://github.com/JuliaDiff/FiniteDifferences.jl/pull/237 is merged this will pass tests.

oxinabox avatar May 20 '24 13:05 oxinabox

What is the current status for this?

avik-pal avatar Jun 09 '24 21:06 avik-pal

Merged. It was just blocked waiting for me to come back and see it passed

oxinabox avatar Jun 10 '24 08:06 oxinabox