ChainRules.jl icon indicating copy to clipboard operation
ChainRules.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaDiff

broadcast type preservation

Open maartenvd opened this issue 2 years ago • 1 comments

appears to solve the diffractor-zygote case in

https://github.com/FluxML/Zygote.jl/issues/1301

@mcabbott

maartenvd avatar Sep 02 '22 11:09 maartenvd

Do you know what the test errors are? Weird it doesn't print them in CI.

Xref comments on testing this a https://github.com/FluxML/Zygote.jl/pull/1302

Edit: note also that https://github.com/JuliaDiff/ChainRules.jl/pull/671/files#r955087897 wants to change CR to use reversed map for this step. A broadcast which iterates backwards would be harder to write.

mcabbott avatar Sep 03 '22 15:09 mcabbott