BlueStyle
BlueStyle copied to clipboard
JuliaDiff
LineLengths=110
I think this is premature. Blue Style is used by hundreds of people and packages outside Invenia, and this is a highly disruptive change (at least when rolled out via the auto formatter). I'd think of this along the lines of a breaking release of a very widely used package that's been stable for a long time.
On a similar, but slightly different poin to the disruptiveness, I also think changing the opinion of the style guide somewhat goes against the spirit of a style guide, that is, the style guide gives the answer to disputed style questions. Where there are currently no answer, we can decide to take an opinion, but changing an answer is a different matter. I kinda think if line length is disputed, we should do what the style guide already says. (And i'm assuming it is disputed i.e. "increase the line length" wouldn't have near universal agreement. If it does, then let's consider it and pick a number (110 could be good, idk), but we have to have figure out the disruptiveness concern).
So I'm not saying this couldn't change, just that it should be well motivated/justified and probably have wider discussion and agreement, imo.
I think this is premature. Blue Style is used by hundreds of people and packages outside Invenia, and this is a highly disruptive change (at least when rolled out via the auto formatter). I'd think of this along the lines of a breaking release of a very widely used package that's been stable for a long time.
On a similar, but slightly different poin to the disruptiveness, I also think changing the opinion of the style guide somewhat goes against the spirit of a style guide, that is, the style guide gives the answer to disputed style questions. Where there are currently no answer, we can decide to take an opinion, but changing an answer is a different matter. I kinda think if line length is disputed, we should do what the style guide already says. (And i'm assuming it is disputed i.e. "increase the line length" wouldn't have near universal agreement. If it does, then let's consider it and pick a number (110 could be good, idk), but we have to have figure out the disruptiveness concern).
So I'm not saying this couldn't change, just that it should be well motivated/justified and probably have wider discussion and agreement, imo.
This issue has been open for 1.5years. I think a better solution might just be me setting up formatters so I can style the code however I want locally, then format according to an agreed upon standard before committing changes. That way all these pointless discussions never have to happen. 🤔
One thing is this is not a "breaking" change. Decreasing the line limit is breaking, increasing it is fine. Anything that followed the guide before still follows it afterwards. Though we often make breaking changes when we do add a rule for something the guide had no opinion on.
I do agree this is likely to be very disruptive
