ImplicitDifferentiation.jl icon indicating copy to clipboard operation
ImplicitDifferentiation.jl copied to clipboard

Remove Krylov dep & add 1.8 testing

Open gdalle opened this issue 3 years ago • 1 comments

gdalle avatar Jul 21 '22 10:07 gdalle

Codecov Report

Merging #15 (1da4c8f) into main (bae6483) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         2    +1     
  Lines           42        50    +8     
=========================================
+ Hits            42        50    +8     
Impacted Files Coverage Δ
src/ImplicitDifferentiation.jl 100.00% <ø> (ø)
src/implicit_function.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bae6483...1da4c8f. Read the comment docs.

codecov[bot] avatar Jul 21 '22 10:07 codecov[bot]

Closing this since removing Krylov seems like a bad idea. It's very lightweight and other packages are not compatible with LinearOperators. I'll do the necessary changes for 1.8 testing on another branch

gdalle avatar Aug 29 '22 12:08 gdalle