ImplicitDifferentiation.jl icon indicating copy to clipboard operation
ImplicitDifferentiation.jl copied to clipboard

Experimental ReverseDiff support

Open gdalle opened this issue 2 years ago • 6 comments

Partial answer to #46

Problems:

  • Because of https://github.com/JuliaDiff/ReverseDiff.jl/issues/238, I was forced to dispatch the default rrule (with no RuleConfig) onto ReverseDiff, which seems arbitrary
  • Computing jacobians in the precompilation step of the ReverseDiff extension kills Julia brutally (it works in normal code)
  • ReverseDiff errors when byproducts are returned, and I don't know how to fix that

Ping @mohamed82008 for help

gdalle avatar Sep 14 '23 18:09 gdalle

Gentle bump @mohamed82008 if you have comments to spare

gdalle avatar Oct 05 '23 07:10 gdalle

I won't have a chance to look into this for the next 3 weeks unfortunately.

mohdibntarek avatar Oct 05 '23 07:10 mohdibntarek

OK no worries, it's low priority

gdalle avatar Oct 05 '23 07:10 gdalle

@mohamed82008 I'd love your take on this one if you have some time. I recently started using ReverseDiff more and I rather like it!

gdalle avatar Feb 09 '24 08:02 gdalle

I have a deadline in a few days and a queue of people to get back to. I will take a look but probably won't be in the coming week.

mohdibntarek avatar Feb 09 '24 16:02 mohdibntarek

No worries!

gdalle avatar Feb 09 '24 21:02 gdalle