LoweredCodeUtils.jl icon indicating copy to clipboard operation
LoweredCodeUtils.jl copied to clipboard

Recognize Core.declare_const in get_lhs_rhs

Open xal-0 opened this issue 7 months ago • 3 comments

This is the minimal change to get Revise working with ~~JuliaLang/julia#57470~~ https://github.com/JuliaLang/julia/pull/58187.

Comparison of lowering of const foo = 1:

version
1.11 Expr(:const, :foo), Expr(:(=), :foo, 1) (with edge 2 -> 1)
1.12 Expr(:const, :foo, 1)
1.13 Expr(:call, Core.declare_const, :foo, 1)

xal-0 avatar Apr 30 '25 18:04 xal-0

It looks like this is required after https://github.com/JuliaLang/julia/pull/58187?

aviatesk avatar May 05 '25 07:05 aviatesk

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.86%. Comparing base (550a2a4) to head (c5e5c97). Report is 40 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #129       +/-   ##
===========================================
- Coverage   88.69%   76.86%   -11.83%     
===========================================
  Files           6        6               
  Lines        1442     1526       +84     
===========================================
- Hits         1279     1173      -106     
- Misses        163      353      +190     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 05 '25 07:05 codecov[bot]

It looks like this is required after JuliaLang/julia#58187?

Issue autocomplete strikes again. That's the one I intended to link.

xal-0 avatar May 05 '25 18:05 xal-0

Thanks @xal-0 !

Comparison of lowering of const foo = 1:

😆 Will we ever make up our minds?!?

timholy avatar Jul 26 '25 11:07 timholy