JuliaInterpreter.jl icon indicating copy to clipboard operation
JuliaInterpreter.jl copied to clipboard

Testing Revise asserts in JuliaInterpreter on 1.9

Open KristofferC opened this issue 2 years ago • 3 comments

From Revise tests:

(jl_Sw1Slv) pkg> add Revise; test Revise
...
beginning signatures tests
julia: /source/src/jltypes.c:2005: jl_reinstantiate_inner_types: Assertion `ndt->types == ((void *)0)' failed.

[9] signal (6.-6): Aborted
in expression starting at /home/pkgeval/.julia/packages/Revise/Kw99o/test/sigtest.jl:106
gsignal at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
abort at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 0x7f0674ecc40e)
__assert_fail at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
jl_reinstantiate_inner_types at /source/src/jltypes.c:2005
jl_f__typebody at /source/src/builtins.c:1731
_jl_invoke at /source/src/gf.c:2739 [inlined]
ijl_apply_generic at /source/src/gf.c:2940
jl_apply at /source/src/julia.h:1879 [inlined]
do_apply at /source/src/builtins.c:730
maybe_evaluate_builtin at /home/pkgeval/.julia/packages/JuliaInterpreter/ktCFr/src/builtins.jl:114

https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/9aa7669_vs_7b39515/Revise.primary.log

KristofferC avatar Apr 14 '23 06:04 KristofferC

Can you explain why you suspect this is a JuliaInterpreter bug and not a Julia bug?

timholy avatar Apr 14 '23 09:04 timholy

No, I just know we call some internal stuff in JuliaInterpreter so I thought I would open it here first. If it turns out to be a Julia bug, we can transfer it there but I think we need to do a bit more work for that first.

At least, that is how I look at things, if you use a bunch of internals and your package starts failing / asserting, you, at least, need to put in the effort to show that the problem is indeed with Julia, and not your usage of the internals. I haven't put in that work yet.

KristofferC avatar Apr 14 '23 09:04 KristofferC

Excellent, thanks for clarifying. Good instincts too (as always).

timholy avatar Apr 14 '23 10:04 timholy