JuliaInterpreter.jl icon indicating copy to clipboard operation
JuliaInterpreter.jl copied to clipboard

WIP: Fixing Julia tests

Open goerch opened this issue 4 years ago • 5 comments

This commit contains the changes needed to make the tests running locally against the installed Julia tests.

goerch avatar Dec 10 '21 10:12 goerch

Codecov Report

Merging #508 (50f35b6) into master (10fd8fc) will increase coverage by 0.89%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
+ Coverage   82.76%   83.65%   +0.89%     
==========================================
  Files          12       12              
  Lines        2443     2405      -38     
==========================================
- Hits         2022     2012      -10     
+ Misses        421      393      -28     
Impacted Files Coverage Δ
src/interpret.jl 81.02% <0.00%> (+9.04%) :arrow_up:
src/types.jl 67.51% <ø> (-5.74%) :arrow_down:
src/construct.jl 84.90% <62.50%> (-4.59%) :arrow_down:
src/optimize.jl 96.91% <0.00%> (-0.01%) :arrow_down:
src/precompile.jl 0.00% <0.00%> (ø)
src/utils.jl 85.47% <0.00%> (+0.60%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10fd8fc...50f35b6. Read the comment docs.

codecov[bot] avatar Dec 10 '21 11:12 codecov[bot]

These are the tests which seem to be most time consuming or not terminating:

interrupting channels
interrupting precompile
interrupting subtype
interrupting worlds

goerch avatar Dec 12 '21 01:12 goerch

Nice to see this getting worked on again!

KristofferC avatar Dec 12 '21 10:12 KristofferC

The current critical problem with channels is reported in #153. For subtype I hit AssertionError("is_leaf(frame)") in step_expr!. In which of my branches do you want me to try to fix this?

goerch avatar Dec 12 '21 13:12 goerch

Nice to see this getting worked on again!

I'm not sure how to proceed with this patch. In its original form it intended to make the tests runnable on Windows (BTW, is the repository version working on other platforms?). I'd be willing to revert it to this initial form in order to keep the changes small and establish a baseline for further improvements regarding #13. Is this the way to go?

goerch avatar Jan 01 '22 12:01 goerch