SQLite.jl
SQLite.jl copied to clipboard
add test for query with strict keyword
kwargs in DBInterface will transform to params, therefore strict will be always false in SQLite 1.6.0
Keywords in definition of DBInterface.execute in SQLite is shadowed by keyword argument version in DBInterface and they are packed with SQL parameters as a whole.
https://github.com/JuliaDatabases/DBInterface.jl/blob/85891482dfc5cd2c6c7c40adaf96ad813c9f0a6d/src/DBInterface.jl#L151
So I think we should remove allowduplicates::Bool = false, strict::Bool = false in function definition as well, but it feels a little strange because we extract two special names from SQL parameters.
What is your opinion @quinnj?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.63%. Comparing base (
3e576b9) to head (77a6f4a). Report is 9 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 93.60% 93.63% +0.03%
==========================================
Files 4 4
Lines 563 566 +3
==========================================
+ Hits 527 530 +3
Misses 36 36
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Yeah, I don't love having to extra the keyword args from the params; let me try to think of an alternative solution here.