TypedTables.jl icon indicating copy to clipboard operation
TypedTables.jl copied to clipboard

Register new Julia v1.2 compatible version of TypedTables

Open oschulz opened this issue 6 years ago • 12 comments

The current version of TypedTables in the Julia registry (v1.1.0) hangs on Julia v1.2. Could we register the current master (resp. commit 59773eb) via @JuliaRegistrator register?

oschulz avatar Jun 17 '19 08:06 oschulz

Hey @andyferris , sorry for nagging you about this. I'm just in a bit of a bind with TypedTables not running on Julia 1.2, because it currently blocks Travis/Appveyor testing for several of my packages on 1.2, and blocks BAT.jl completely (BAT.jl ran on Julia 1.0 and 1.1, but 1.0.1 and 1.1.1 kinda broke it, so since the release of those it really needs 1.2-rc because that fixes Julia issue #31666).

If Registrator is active on TypedTables, a commit comment @JuliaRegistrator register on https://github.com/FugroRoames/TypedTables.jl/commit/59773eba5725dea94ff182996dfe8cdf8c5d0e4c should be enough (assuming I did everything right in Project.toml).

oschulz avatar Jun 19 '19 12:06 oschulz

Hi @andyferris I believe I have the same problem : j've added TypedTables in v1.2 and precompilation takes for ever, never to completion or error message (and still using about 25% memory so seems alive). I don't know what to do to you help fix this, but if you have some pointers I might try and give it a go. Thanks

The backtrace shows up when I kill the precompile with C-c : (this is on Win10)

using TypedTables [ Info: Precompiling TypedTables [9d95f2ec-7b3d-5a63-8d20-e2491e220bb9] ERROR: InterruptException: Stacktrace: [1] poptaskref(::Base.InvasiveLinkedListSynchronized{Task}) at .\task.jl:564 [2] wait() at .\task.jl:591 [3] wait(::Base.GenericCondition{Base.AlwaysLockedST}) at .\condition.jl:104 [4] stream_wait(::Base.Process, ::Base.GenericCondition{Base.AlwaysLockedST}) at .\stream.jl:47 [5] wait at .\process.jl:956 [inlined] [6] success at .\process.jl:771 [inlined] [7] compilecache(::Base.PkgId, ::String) at .\loading.jl:1245 [8] _require(::Base.PkgId) at .\loading.jl:1013 [9] require(::Base.PkgId) at .\loading.jl:911 [10] require(::Module, ::Symbol) at .\loading.jl:906

samusz avatar Jun 21 '19 10:06 samusz

Gentle bump @andyferris . We'd like to do a new release of BAT.jl, but it won't install without a new Julia-v1.2-compatible release of TypedTables. I'm really sorry to bother you, Andy, I can imagine that you're very busy with JuliaCon coming up ... but if you could find a moment to trigger Registrator, I'd be very grateful!

oschulz avatar Jun 24 '19 21:06 oschulz

Hmm - sorry for being unresponsive - I’m currently in the middle of a four week tour of central Australia. Not much internet and even less computers.

I’ve also haven’t used Registrator yet... let’s see how I can help.

andyferris avatar Jun 24 '19 21:06 andyferris

@JuliaRegistrator register

andyferris avatar Jun 24 '19 21:06 andyferris

Registration pull request created: JuliaRegistries/General/1547

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:

git tag -a v1.2.0 -m "<description of version>" fc1247a590be301341d172d447f706347bed727e
git push origin v1.2.0

JuliaRegistrator avatar Jun 24 '19 21:06 JuliaRegistrator

Ok so I installed Registrator and Tagbot. Does anyone know what happens with github releases and github docs?

andyferris avatar Jun 24 '19 21:06 andyferris

Hmm - sorry for being unresponsive - I’m currently in the middle of a four week tour of central Australia.

Sorry for disturbing your trip!

oschulz avatar Jun 24 '19 22:06 oschulz

Ok so I installed Registrator and Tagbot. Does anyone know what happens with github releases and github docs?

Tagbot should take care of creating the GitHub release - though in this cases, I don't know what'll happen, since you created the release manually already a while back.

Documenter docs generation seemed unaffected by the switch to Registrator, with my packages.

oschulz avatar Jun 24 '19 22:06 oschulz

No worries, @oschulz. Luckily you got me at a moment where I have 4G coverage, a charged phone and no children nagging me (probably the first such concurrence for a week ;) ).

And yeah, unfortunately I won’t be making JuliaCon this year but if you are going - have fun!

andyferris avatar Jun 24 '19 23:06 andyferris

Luckily you got me at a moment where I have 4G coverage, a charged phone and no children nagging me

I can imagine, @andyferris ! :-) Have lot's of fun, down under!

oschulz avatar Jun 25 '19 05:06 oschulz

Registration of v1.2 went trough fine, thanks again!

TagBot failed, the version that was registered is one commit ahead (I think) of your manual 1.2 release. @andyferris, at some point, when you have a network connection again, you may want to delete your manual release, and trigger TagBot again (see bottom of JuliaRegistries/General#1547. It's not time critical at all though, of course.

It's more of a cosmetic/consistency thing, of course - I'll just leave this issue open so we won't forget.

oschulz avatar Jun 28 '19 07:06 oschulz