JuliaDB.jl icon indicating copy to clipboard operation
JuliaDB.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaData

Update type mutability check in IO.jl

Open mrufsvold opened this issue 3 years ago • 2 comments

Fix bug (https://github.com/JuliaData/JuliaDB.jl/issues/408) that causes loading from a bin directory to fail due to deprecated type mutability check.

Changes:

  • Update IO.jl to use ismutabletype()
  • Change Julia compat bound to 1.6

mrufsvold avatar Feb 22 '22 20:02 mrufsvold

LGTM! I'd like another maintainer to confirm that the Julia 1.6 compat bound looks good before merging.

jpsamaroo avatar Feb 23 '22 03:02 jpsamaroo

Yo, sorry I dropped off the face of the planet. I removed the 1.6 requirement from compat, and created the version check for 1.7.

I basically just copied your code except that I defined gave the new function the name _ismutabletype so that I did not get an error about redefining a constant.

I only have 1.7 installed on my system, so I didn't test this on earlier versions of Julia.

tagging @joshday and @jpsamaroo for visibility

mrufsvold avatar Mar 28 '22 15:03 mrufsvold