JSONTables.jl icon indicating copy to clipboard operation
JSONTables.jl copied to clipboard

jsontable(x::AbstractVector{<:JSON3.Object})

Open anandijain opened this issue 2 years ago • 2 comments

@quinnj

This PR making me realize I'm bad at type parameters, I think we still want the jsontable(x::JSON3.Array) dispatch that I commented out.

Should I make it jsontable(x::JSON3.Array{Any}) or something?

Thanks

anandijain avatar Oct 06 '22 18:10 anandijain

I think just uncommenting it should be fine? Were you seeing issues not specifying a type paramter?

quinnj avatar Oct 06 '22 22:10 quinnj

Codecov Report

Base: 91.57% // Head: 92.55% // Increases project coverage by +0.97% :tada:

Coverage data is based on head (c6fac42) compared to base (239f4f2). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   91.57%   92.55%   +0.97%     
==========================================
  Files           1        1              
  Lines          95       94       -1     
==========================================
  Hits           87       87              
+ Misses          8        7       -1     
Impacted Files Coverage Δ
src/JSONTables.jl 92.55% <100.00%> (+0.97%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 06 '22 22:10 codecov[bot]