DataFramesMeta.jl Remove @with, add @attach

fixes #364

Oct 31 '23 22:10 pdeffebach

CI errors

I do not see where you deprecate @with (I think we should keep it at least for a while). @nalimilan - what do you think?

Nov 01 '23 12:11 bkamins

Tests pass

Nov 01 '23 16:11 pdeffebach

There are some doctest failures

Nov 02 '23 13:11 bkamins

This can be a small version bump, right? Since it just deprecates, we don't need to make a 0.15.0 version.

Nov 07 '23 22:11 pdeffebach

we add new @attach. In the past, we would e.g. in DataFrames.jl make 0.15 release. But recently people were saying that such minor changes are OK to be made in 0.14.2.

Nov 07 '23 22:11 bkamins

Okay I'm just going to merge this with a minor version bump. I don't want to release too many breaking changes and I want people to see the deprecation.

I will also announce on discourse soon.

Dec 14 '23 18:12 pdeffebach

OK

Dec 14 '23 19:12 bkamins

Sorry, for some reason I missed this. It's really unfortunate that Julia exports this general name now. Have you considered calling it @within instead of @attach (which indeed has a bad reputation in R as it attaches copies of columns to the global environment)?

Dec 14 '23 21:12 nalimilan

@within is a good name. I guess I still prefer @attach since

It's a verb, kind of like @select, @transform etc.
I like the idea of us re-doing an R feature, but "correctly", without the scoping and performance drawbacks of attach.

Dec 18 '23 20:12 pdeffebach

Closing this due to https://github.com/JuliaLang/julia/pull/53004#issuecomment-1981109599 being merged

Mar 28 '24 15:03 pdeffebach