DataFrames.jl icon indicating copy to clipboard operation
DataFrames.jl copied to clipboard

Add documentation for JLD2 I/O

Open alex-s-gardner opened this issue 2 years ago • 3 comments

Addresses #3364

alex-s-gardner avatar Jul 29 '23 02:07 alex-s-gardner

I have left some stylistic comments.

Additionally, since I am not using JLD2 format myself. The question is how does it handle saving SubDataFrame, or GroupedDataFrame (I assume that it saves them correctly by strong both the view object and the underlying DataFrame?).

bkamins avatar Aug 01 '23 10:08 bkamins

The question is how does it handle saving SubDataFrame, or GroupedDataFrame (I assume that it saves them correctly by strong both the view object and the underlying DataFrame?).

I tested saving and loading both SubDataFrame and GroupedDataFrame and they seem to work just fine... is this something that we should mention?

maybe here:

.... , JLD2 preserves custom Types including SubDataFrame and GroupedDataFrame.

alex-s-gardner avatar Aug 01 '23 22:08 alex-s-gardner

Sorry for a delay. I think it is OK the way you proposed. Just can you please move JLD2 after CSV (as CSV is for sure more popular).

Also @nalimilan - could you please have a look at wording of the PR?

bkamins avatar Sep 25 '23 21:09 bkamins