DataFrames.jl icon indicating copy to clipboard operation
DataFrames.jl copied to clipboard

nrow and ncol for DataFrameRows and DataFrameColumns

Open bkamins opened this issue 2 years ago • 4 comments

@nalimilan: Do we want DataFrameRows and DataFrameColumns to be considered to be Tables.jl tables and eg. define for them nrow and ncol?

bkamins avatar May 20 '22 09:05 bkamins

What's the context of this? I don't see a strong reason not to do this but better have use cases before adding features?

nalimilan avatar May 20 '22 10:05 nalimilan

The context is https://github.com/JuliaData/Tables.jl/pull/278#issuecomment-1132706343. If we decide to add nrow and ncol support for Tables.jl tables in general and decide to treat these two types as tables (apart of treating AbstractDataFrame as table) then we should add this support.

bkamins avatar May 20 '22 13:05 bkamins

OK. Let's wait until a decision is made in Tables.jl first?

nalimilan avatar May 23 '22 19:05 nalimilan

Yes, I just want to track this here.

bkamins avatar May 23 '22 20:05 bkamins