DataFrames.jl
DataFrames.jl copied to clipboard
Post PrettyTables.jl housekeeping
@ronisbr - I open this issue to keep track of to-do related to PrettyTables.jl:
- coverage of show.jl is quite poor now: https://codecov.io/gh/JuliaData/DataFrames.jl/tree/master/src/abstractdataframe; it would be great to add more tests at some point (this point should be reviewed after https://github.com/JuliaData/DataFrames.jl/pull/2522 is merged as I did some clean up there)
- add section in the manual on configuring PrettyTables.jl
- add HTML and LaTeX backends
Good!
Just one question about 1: maybe I am mistaken, but the code snippets that are not tested seem to be related to the old printing mechanism, which are not used anymore. Am I wrong? The only line that is not tested in _show
is the one that blocks floating point alignment if we have more than 200,000 cells.
Am I wrong?
That is why I say that we should wait for https://github.com/JuliaData/DataFrames.jl/pull/2522 as it removes them (and then probably it will be clean).
Still I think we do not have custom PrettyTalbles.jl kwarg
tests (I assume that when manual entry is written it can be also used as additional tests).
Oh sorry, I am a bit lazy today 😊 Yes, we definitely should add tests with custom options of PrettyTables (at least the most common);
PRs like https://github.com/JuliaData/DataFrames.jl/pull/2542 show that it would be good to go back to this housekeeping issue at some moment (no rush - as probably everyone needs a break now :smile:; I am updating tutorials).