Keyword argument consistency: missingstring -> missingstrings

Open getzze opened this issue 3 years ago • 1 comments

I was thinking it would be more consistent to use missingstrings instead of missingstring, for consistency with truestrings and falsestrings. And maybe accept only Union{AbstractVector{<:AbstractString}, Nothing} and not String as type, again for consistency with truestrings/falsestrings.

[Edit] I just saw that missingstring is a kwarg in CSV.write(). But is it really needed in CSV.write, as we have a transform kwarg that is more powerful? The default missing->"" could be hardcoded and people can use transform if they need something else. Anyway I find it more confusing to have missingstring/truestrings/falsestrings is CSV.File than missingstring in write and missingstrings in File.

Apr 08 '22 10:04 getzze

i think this used to be the naming but we changed to the singular in https://github.com/JuliaData/CSV.jl/pull/846

Apr 08 '22 11:04 nickrobinson251