DSP.jl icon indicating copy to clipboard operation
DSP.jl copied to clipboard

add F-test to mt_pgram

Open bjarthur opened this issue 7 months ago • 4 comments

fixes https://github.com/JuliaDSP/DSP.jl/issues/632

bjarthur avatar May 05 '25 21:05 bjarthur

Codecov Report

:x: Patch coverage is 17.39130% with 19 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 97.57%. Comparing base (08f4b0f) to head (c11fe30). :warning: Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/multitaper.jl 19.04% 17 Missing :warning:
src/periodograms.jl 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
- Coverage   98.13%   97.57%   -0.57%     
==========================================
  Files          19       19              
  Lines        3277     3299      +22     
==========================================
+ Hits         3216     3219       +3     
- Misses         61       80      +19     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 07 '25 12:05 codecov[bot]

this PR works great locally. if you are inclined to add this feature, i'll add some docs and tests. let me know!

bjarthur avatar May 07 '25 13:05 bjarthur

@wheeheee @martinholters please let me know if you're interested in this draft PR and i'll add some docs and tests

bjarthur avatar May 23 '25 13:05 bjarthur

Interesting, but not sure if it's gonna be useful for most of the current user base?

wheeheee avatar May 28 '25 12:05 wheeheee