DSP.jl icon indicating copy to clipboard operation
DSP.jl copied to clipboard

Merge Estimation.jl into DSP.jl?

Open ssfrr opened this issue 5 years ago • 2 comments

copied from https://github.com/orgs/JuliaDSP/teams/developers/discussions/1:

@rob-luke:

I need to use the APES method in JuliaDSP/Estimation.jl and will update it for Julia v1.0 (I wrote the original code). Given that there is now a Estimation section in JuliaDSP/DSP.jl should I just merge the entire estimation package in to DSP.jl and close Estimation.jl? The reason I would think not to merge the packages is that APES and Quinn Fernandes are more obscure than the ESPRIT algorithm, so if we want to keep DSP.jl lean then I've never used this team discussion thing, so IMO an Issue on DSP.jl or Estimation.jl is probably the best place to discuss.

ssfrr avatar Sep 17 '18 17:09 ssfrr

I've never used this team discussion thing, so IMO an Issue on DSP.jl or Estimation.jl is probably the best place to discuss.

IMO fewer packages are easier to maintain than more packages, and particularly if you're continuing to maintain the code I'm not too worried about DSP.jl getting too bloated as long as the functionality is relevant.

That said I haven't reviewed the estimation API at all and am not familiar with the code, so if we're growing the estimation functionality of DSP.jl it might be a good time to make sure there's a unified interface if possible.

ssfrr avatar Sep 17 '18 17:09 ssfrr

Great, I will take a look at updating the APES code and bringing the interface in line with the rest of DSP.

rob-luke avatar Sep 17 '18 22:09 rob-luke