SHA.jl
SHA.jl copied to clipboard
Remove `Base.getproperty`
After removing Base.getproperty, you need to check if the exported API is type stable and how the performance changes.
https://github.com/JuliaCrypto/SHA.jl/blob/918aff1fd132034d19a940894106db2c97d8e977/src/types.jl#L42-L54
https://github.com/JuliaCrypto/SHA.jl/blob/918aff1fd132034d19a940894106db2c97d8e977/src/types.jl#L90-L102
@staticfloat I think it is safe to close this based on the linked PR :D
it is safe to close this
Nope, Base.getproperty is still in the code base.
We may need to check the type stability and performance of each API after removing getproperty. I will open a new issue to track this. (77)
This issue is opened after pr 75.