OrderedCollections.jl icon indicating copy to clipboard operation
OrderedCollections.jl copied to clipboard

Does LittleDict show too much about the implementation?

Open PallHaraldsson opened this issue 5 years ago • 8 comments

I noticed:

julia> x = LittleDict{String, Int}()
LittleDict{String, Int64, Vector{String}, Vector{Int64}}()

should it show similar to other Dicts:

LittleDict{String, Int64}()

I also noticed for a recursive one:

julia> x = LittleDict{LittleDict, Int}()
LittleDict{LittleDict, Int64, Vector{LittleDict}, Vector{Int64}}()

julia> x
LittleDict{LittleDict, Int64, Vector{LittleDict}, Vector{Int64}} with 1 entry:
  LittleDict{LittleDict, Int64, Vector{LittleDict}, Vector{Int64}}(#= circular reference @-1 =#) => 0

this "circular reference" is not shown for other dicts (I'm not saying it's untrue). I just noticed this compared to: #65.

PallHaraldsson avatar Oct 23 '20 16:10 PallHaraldsson

The culprit was actually simple to find. Shims must follow the naming convention io.containerd.*:

https://github.com/containerd/nerdctl/blob/2eeffe086961098f2e040f784c1707a1adc1cdb4/pkg/cmd/container/run_runtime.go#L41-L43

antoineco avatar Aug 02 '23 07:08 antoineco

HI @antoineco

When I try to investigate the issue and run with docker.

root@kay200:~# docker container create --runtime com.example.sample.v1 docker.m.daocloud.io/nginx:alpine
Error response from daemon: Unknown runtime specified com.example.sample.v1

So Does the expected result need to be the same with docker :-)

yankay avatar Aug 04 '23 04:08 yankay

I guess that's fine for me. If shims for containerd need to follow a certain naming convention I'll follow that convention.

antoineco avatar Aug 04 '23 05:08 antoineco

This is still a bug

AkihiroSuda avatar Aug 04 '23 06:08 AkihiroSuda

any update?

zhangguanzhang avatar Apr 27 '24 12:04 zhangguanzhang