FunctionalCollections.jl icon indicating copy to clipboard operation
FunctionalCollections.jl copied to clipboard

`filter` on `PersistentHashMap` inconsistent with `Base`

Open TotalVerb opened this issue 8 years ago • 0 comments

The Base version of filter on Dict requires a function that takes two arguments. That's not the case for PersistentHashMap. Arguably, the existing FunctionalCollections behaviour makes more sense; I've filed https://github.com/JuliaLang/julia/issues/17886 over in Base. If Base transitions to one-argument, then nothing needs to be done; otherwise, I feel like PersistentHashMap must be changed too to avoid the surprise factor.

TotalVerb avatar Aug 08 '16 04:08 TotalVerb