DataStructures.jl
DataStructures.jl copied to clipboard
Optimisation: Use heapify in MutableBinaryHeap
Fixes: https://github.com/JuliaCollections/DataStructures.jl/issues/639
Note: I was a little confused by the issue-description, so not sure if the changes I made are at the correct place.
@AquaIndigo can you review?
CI fails so i suspect this is not correct
Turned out I haven't updated nodemap
after calling heapify
. I am wondering if we can do that efficiently (without using extra space).
Or does the issue intend to use heapify
at some other place @AquaIndigo? (That was the confusion that I mentioned here)
Turned out I haven't updated
nodemap
after callingheapify
. I am wondering if we can do that efficiently (without using extra space).Or does the issue intend to use
heapify
at some other place @AquaIndigo? (That was the confusion that I mentioned here)
I think that heapify!
could help.
I ran the tests locally, it was all green.
Sorry for taking so long to review this. I lost track of it
It may also need rebasing to get out new CI setup to work